[improve] openmldb options#9166
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the OpenMLDB connector options and parameters while updating the source to use CatalogTable for schema conversion. Key updates include:
- Renaming configuration classes from OpenMldbConfig to OpenMldbSourceOptions and updating references accordingly.
- Refactoring OpenMldbSource to use a constructor for initialization, converting schema to a CatalogTable, and updating the reader creation.
- Adjustments in testing to reflect the new naming conventions for configuration options.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| seatunnel-connectors-v2/connector-openmldb/src/main/java/org/apache/seatunnel/connectors/seatunnel/openmldb/source/OpenMldbSourceFactory.java | Updated option references and added createSource method implementation. |
| seatunnel-connectors-v2/connector-openmldb/src/main/java/org/apache/seatunnel/connectors/seatunnel/openmldb/source/OpenMldbSource.java | Removed prepare() method and refactored schema conversion to return a CatalogTable. |
| seatunnel-connectors-v2/connector-openmldb/src/main/java/org/apache/seatunnel/connectors/seatunnel/openmldb/config/OpenMldbSourceOptions.java | Renamed configuration class and updated its content accordingly. |
| seatunnel-connectors-v2/connector-openmldb/src/main/java/org/apache/seatunnel/connectors/seatunnel/openmldb/config/OpenMldbParameters.java | Updated to work with the new SourceOptions. |
| seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java | Removed OpenMldbSourceOptions from the whitelist as part of the name change. |
Comments suppressed due to low confidence (1)
seatunnel-connectors-v2/connector-openmldb/src/main/java/org/apache/seatunnel/connectors/seatunnel/openmldb/source/OpenMldbSource.java:143
- The table name is hardcoded as "default" in the TableIdentifier. Consider making it configurable or more descriptive to better reflect the underlying data schema.
TableIdentifier.of("OpenMldb", openMldbParameters.getDatabase(), "default")
Hisoka-X
approved these changes
Apr 25, 2025
hailin0
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.