close
Skip to content

[Feature][Zeta] Support basic authentication for web ui#9171

Merged
Hisoka-X merged 12 commits into
apache:devfrom
CosmosNi:feature_http_auth
Apr 17, 2025
Merged

[Feature][Zeta] Support basic authentication for web ui#9171
Hisoka-X merged 12 commits into
apache:devfrom
CosmosNi:feature_http_auth

Conversation

@CosmosNi

@CosmosNi CosmosNi commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Support Basic Authentication for web ui
close #9043

2025-04-16.15.05.51-1.mov

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hailin0 hailin0 requested a review from Copilot April 14, 2025 06:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.


/** Test that accessing the REST API with correct credentials returns 200 OK. */
@Test
public void testRestApiAccessWithCorrectCredentials() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new test case with testRestApiAccessWithIncorrectCredentials

@hailin0 hailin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upload a screenshot of the page

ref
#7818 (comment)

Comment thread docs/zh/seatunnel-engine/security.md Outdated

# Security

## 基本认证

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 基本认证
## Basic 认证

Comment thread docs/zh/seatunnel-engine/security.md Outdated
Comment thread docs/zh/seatunnel-engine/security.md Outdated
Comment thread docs/en/seatunnel-engine/security.md

@hailin0 hailin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

waiting for ci passed

Hisoka-X
Hisoka-X previously approved these changes Apr 16, 2025
@Hisoka-X Hisoka-X changed the title [Feature][Zeta] Support Basic Authentication for web ui [Feature][Zeta] Support basic authentication for web ui Apr 16, 2025
@hailin0

hailin0 commented Apr 16, 2025

Copy link
Copy Markdown
Member

waiting for ci passed

hailin0
hailin0 previously approved these changes Apr 17, 2025
@CosmosNi CosmosNi dismissed stale reviews from hailin0 and Hisoka-X via b87ecd3 April 17, 2025 01:40
@Hisoka-X Hisoka-X merged commit 19871a7 into apache:dev Apr 17, 2025
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Zeta] Support Basic Authentication for web ui

4 participants