[Fix][Connector-V2] Fix kafka database name#9201
Merged
Merged
Conversation
hailin0
reviewed
Apr 21, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue with the Kafka connector’s database naming by refactoring the table path construction logic. Key changes include:
- Extraction of the table path resolution into a new method (getTablePathFromSchema) for improved flexibility.
- Updates to the catalog table creation to use the new table path resolution.
- Addition of a new unit test (testDeserializationWithSchema) to validate deserialization behavior when a schema is provided.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| seatunnel-connectors-v2/connector-kafka/src/test/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfigTest.java | Added a unit test to verify deserialization with a provided schema and table identifier. |
| seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfig.java | Refactored the table path construction by extracting logic into getTablePathFromSchema to fix database naming issues. |
Comments suppressed due to low confidence (2)
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfig.java:265
- Ensure that the schema configuration key is used consistently across the connector. You might consider aligning the usage of KafkaSourceOptions.SCHEMA and TableSchemaOptions.SCHEMA to prevent potential misconfiguration.
readonlyConfig.getOptional(TableSchemaOptions.SCHEMA)
seatunnel-connectors-v2/connector-kafka/src/test/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfigTest.java:86
- [nitpick] Consider clarifying the test table identifier format (e.g., separating database and table parts) to ensure it aligns with production expectations and avoids ambiguity.
schema.put(TABLE.key(), "test.test");
Hisoka-X
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.