close
Skip to content

[Fix][Doc] Delete space before _test and _sink#9216

Merged
davidzollo merged 1 commit into
apache:devfrom
kehan-zhou:fix-pgdoc-suffix-spacing
Apr 23, 2025
Merged

[Fix][Doc] Delete space before _test and _sink#9216
davidzollo merged 1 commit into
apache:devfrom
kehan-zhou:fix-pgdoc-suffix-spacing

Conversation

@kehan-zhou

@kehan-zhou kehan-zhou commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Purpose of this pull request

This pull request fixes formatting issues in the PostgreSQL documentation where a space was mistakenly added before suffixes like _test and _sink in example table names.
Examples fixed:

  • ${schema_name}.${table_name} _test${schema_name}.${table_name}_test
  • dbo.tt_${table_name} _sinkdbo.tt_${table_name}_sink

This improves accuracy and consistency in documentation.

Related Issue: Fixes #9214


Does this PR introduce any user-facing change?

Yes. It corrects table name formatting in the documentation, which users may refer to when configuring connectors or writing SQL.
There is no behavioral change to SeaTunnel itself.


How was this patch tested?

This patch was tested by manually reviewing the affected documentation files to ensure the formatting was corrected.


Check list

@nielifeng nielifeng requested a review from Copilot April 23, 2025 10:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes formatting issues in the PostgreSQL documentation by removing extraneous spaces before the suffixes "_test" and "_sink" in example table names.

  • Corrected examples in Chinese documentation
  • Corrected examples in English PostgreSQL documentation
  • Corrected examples in English JDBC documentation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/zh/connector-v2/sink/PostgreSql.md Removed the extra space before "_test" and "_sink".
docs/en/connector-v2/sink/PostgreSql.md Removed the extra space before "_test" and "_sink".
docs/en/connector-v2/sink/Jdbc.md Removed the extra space before "_test" and "_sink".

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kehan-zhou

@davidzollo davidzollo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
good job, thx

@davidzollo davidzollo merged commit 0fed6f6 into apache:dev Apr 23, 2025
@kehan-zhou kehan-zhou deleted the fix-pgdoc-suffix-spacing branch April 24, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix][Doc] Please help delete the space in the PG doc

4 participants