[Bugifx][kafka] Fix kafka enumerator assign split NPE#9220
Merged
Conversation
Member
Author
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential NullPointerException in the Kafka enumerator's split assignment logic by adding initialization state checks.
- Introduces a volatile boolean flag (initialized) to control when discovery and assignment of splits should occur.
- Updates the discovery logic in open() and the registration logic in registerReader() to respect the new initialization state.
Comments suppressed due to low confidence (1)
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceSplitEnumerator.java:262
- [nitpick] Adding 'initialized' to the condition in registerReader() ensures no premature split assignment. Please confirm that this check does not inadvertently delay processing of pending splits when readers are registered.
if (!pendingSplit.isEmpty() && initialized) {
Hisoka-X
approved these changes
Apr 25, 2025
wuchunfu
approved these changes
Apr 26, 2025
jia17
pushed a commit
to jia17/seatunnel
that referenced
this pull request
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.