close
Skip to content

[Fix][Config] Fix invalid telemetry-log config in seatunnel.yaml#9230

Merged
corgy-w merged 1 commit into
apache:devfrom
mrtisttt:fix-seatunnel-config
Apr 28, 2025
Merged

[Fix][Config] Fix invalid telemetry-log config in seatunnel.yaml#9230
corgy-w merged 1 commit into
apache:devfrom
mrtisttt:fix-seatunnel-config

Conversation

@mrtisttt

Copy link
Copy Markdown
Contributor

Purpose of this pull request

There is an incorrect configuration in config/seatunnel.yaml, which will cause an error to be reported in the logs when starting the Seatunnel service.

config/seatunnel.yaml:

seatunnel:
  engine:
		……
    telemetry:
      metric:
        enabled: false
      log:
        scheduled-deletion-enable: true

When using this configuration, there will be warnings in the service logs:

[] 2025-04-25 15:06:22,410 WARN  [amlSeaTunnelDomConfigProcessor] [main] - Unrecognized element: log

The correct configuration should be "logs" instead of "log":

seatunnel:
  engine:
		……
    telemetry:
      metric:
        enabled: false
      logs:
        scheduled-deletion-enable: true

Does this PR introduce any user-facing change?

No.

How was this patch tested?

When the service starts, it can correctly parse the corresponding configuration.

Check list

@Hisoka-X Hisoka-X requested a review from corgy-w April 25, 2025 07:50
@nielifeng nielifeng requested a review from Copilot April 25, 2025 09:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an invalid telemetry configuration in seatunnel.yaml that causes log warnings during service startup.

  • Correct the telemetry logging configuration by renaming "log" to "logs".
  • Ensures that the Seatunnel service correctly parses the telemetry configuration without generating warnings.

Comment thread config/seatunnel.yaml
metric:
enabled: false
log:
logs:

Copilot AI Apr 25, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming 'log' to 'logs' fixes the misconfiguration issue that causes warnings in the service logs.

Copilot uses AI. Check for mistakes.
@mrtisttt mrtisttt closed this Apr 25, 2025
@Hisoka-X

Copy link
Copy Markdown
Member

Hi @mrtisttt , why closed this?

@mrtisttt

Copy link
Copy Markdown
Contributor Author

Hi @mrtisttt , why closed this?

Hi, I'm concerned whether this fix will be too simplistic. Although it does solve the problem. I'll reopen it to check if it needs to be merged. I'm just starting to get involved in this project recently.

@mrtisttt mrtisttt reopened this Apr 28, 2025

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mrtisttt . cc @corgy-w

@corgy-w corgy-w merged commit 734da06 into apache:dev Apr 28, 2025
@mrtisttt mrtisttt deleted the fix-seatunnel-config branch June 10, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants