close
Skip to content

[improve] qdrant options#9235

Merged
corgy-w merged 1 commit into
apache:devfrom
liunaijie:improve/qdrant_options
Apr 28, 2025
Merged

[improve] qdrant options#9235
corgy-w merged 1 commit into
apache:devfrom
liunaijie:improve/qdrant_options

Conversation

@liunaijie

Copy link
Copy Markdown
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@nielifeng nielifeng requested a review from Copilot April 27, 2025 05:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the Qdrant connector configuration by refactoring the option classes used in both the source and sink implementations. Key changes include replacing the generic QdrantConfig with more specialized classes (QdrantSourceOptions, QdrantSinkOptions, and QdrantBaseOptions) and updating all corresponding references, along with adjusting the connector option rule definitions.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
seatunnel-connectors-v2/connector-qdrant/src/main/java/org/apache/seatunnel/connectors/seatunnel/qdrant/source/QdrantSourceFactory.java Updated references from QdrantConfig to QdrantSourceOptions for consistency.
seatunnel-connectors-v2/connector-qdrant/src/main/java/org/apache/seatunnel/connectors/seatunnel/qdrant/source/QdrantSource.java Changed connector identity reference from QdrantConfig to QdrantBaseOptions.
seatunnel-connectors-v2/connector-qdrant/src/main/java/org/apache/seatunnel/connectors/seatunnel/qdrant/sink/QdrantSinkFactory.java Replaced QdrantConfig with QdrantSinkOptions and updated option rule definition to include COLLECTION_NAME.
seatunnel-connectors-v2/connector-qdrant/src/main/java/org/apache/seatunnel/connectors/seatunnel/qdrant/sink/QdrantSink.java Updated connector identity reference from QdrantConfig to QdrantBaseOptions.
QdrantSourceOptions.java, QdrantSinkOptions.java, QdrantParameters.java, QdrantBaseOptions.java Introduced new option classes and updated key references to support the improved option management.
seatunnel-ci-tools ConnectorOptionCheckTest.java Removed QdrantSinkOptions and QdrantSourceOptions from the whitelist in accordance with the new configuration scheme.

@corgy-w corgy-w merged commit f3a45cd into apache:dev Apr 28, 2025
@liunaijie liunaijie deleted the improve/qdrant_options branch April 29, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants