close
Skip to content

[Fix][Doc] Sink's plugin_input is incorrect configurations#9492

Merged
corgy-w merged 1 commit into
apache:devfrom
e-mhui:patch-1
Jun 24, 2025
Merged

[Fix][Doc] Sink's plugin_input is incorrect configurations#9492
corgy-w merged 1 commit into
apache:devfrom
e-mhui:patch-1

Conversation

@e-mhui

@e-mhui e-mhui commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

@Hisoka-X Hello, pls help to review it.

Sink's plugin_input is incorrect configurations,it should be same with Source's plugin_output. (The English document is correct, but the Chinese document is incorrect.)

Although it does not affect task execution, this is an incorrect method and is not recommended. Placing it in the official documentation can cause confusion.

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X  Hello, pls help to review it.

Sink's `plugin_input` is incorrect configurations,it should be same with Source's `plugin_output`.

Although it does not affect task execution, this is an incorrect method and is not recommended. Placing it in the official documentation can cause confusion. 

https://github.com/apache/seatunnel/blob/9777ecb4e4ed271310d4de65b572acd7f30ae31d/seatunnel-engine/seatunnel-engine-core/src/main/java/org/apache/seatunnel/engine/core/parse/ConfigParserUtil.java#L112

@Hisoka-X Hisoka-X left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @e-mhui

@corgy-w corgy-w merged commit 3af742c into apache:dev Jun 24, 2025
5 checks passed
chncaesar pushed a commit to chncaesar/seatunnel that referenced this pull request Jun 30, 2025
dybyte pushed a commit to dybyte/seatunnel that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants