close
Skip to content

[Feature][Connector-V2] MongodbSink Support SaveMode#9883

Merged
Hisoka-X merged 8 commits into
apache:devfrom
chl-wxp:feature/mongodbSupportSaveMode
Oct 15, 2025
Merged

[Feature][Connector-V2] MongodbSink Support SaveMode#9883
Hisoka-X merged 8 commits into
apache:devfrom
chl-wxp:feature/mongodbSupportSaveMode

Conversation

@chl-wxp

@chl-wxp chl-wxp commented Sep 22, 2025

Copy link
Copy Markdown
Member

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@chl-wxp

chl-wxp commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

I'll hang this pull request here first, and I'll optimize and supplement it later, as well as add unit tests and E2E

@Carl-Zhou-CN

Copy link
Copy Markdown
Member

I'll hang this pull request here first, and I'll optimize and supplement it later, as well as add unit tests and E2E

look forward to

@github-actions github-actions Bot added the e2e label Sep 29, 2025
@chl-wxp

chl-wxp commented Oct 12, 2025

Copy link
Copy Markdown
Member Author

@Carl-Zhou-CN

@chl-wxp

chl-wxp commented Oct 13, 2025

Copy link
Copy Markdown
Member Author

@davidzollo

DataSaveMode.class,
Arrays.asList(DROP_DATA, APPEND_DATA, ERROR_WHEN_DATA_EXISTS))
.defaultValue(APPEND_DATA)
.withDescription("data_save_mode");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a description of him instead of copying the name

Comment thread docs/en/connector-v2/sink/MongoDB.md Outdated
| common-options | | No | - | Source plugin common parameters, please refer to [Source Common Options](../sink-common-options.md) for details |
| data_save_mode | String | No | APPEND_DATA | The data saving mode of mongodb |

### data_save_mode [Enum]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Describing him in the "Description" section of the table would be more in line with the previous format

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit 10c6a6f into apache:dev Oct 15, 2025
5 checks passed
@chl-wxp chl-wxp deleted the feature/mongodbSupportSaveMode branch October 15, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants