close
Skip to content

Print timestamp when --human=true - #438

Merged
thaJeztah merged 1 commit into
docker:masterfrom
boaz0:history_fix
Aug 14, 2017
Merged

Print timestamp when --human=true#438
thaJeztah merged 1 commit into
docker:masterfrom
boaz0:history_fix

Conversation

@boaz0

@boaz0 boaz0 commented Aug 12, 2017

Copy link
Copy Markdown
Contributor

This PR closes #437

- What I did

  • Setting --human=true changes CreatedSince format
  • CreatedAt now displays the creation timestamp as specified in the documents

- How I did it

  • Updated historyContext.CreatedSince and historyContext.CreatedAt in cli/command/formatter/history.go
  • Added a test-case to cli/command/formatter/history_test.go

- How to verify it

Run unit tests

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

* Setting "--human=true" changes "CreatedSince" format

* "CreatedAt" now displays the creation timestamp as
  specified in the documents

Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #438 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #438      +/-   ##
=========================================
+ Coverage   46.28%   46.3%   +0.02%     
=========================================
  Files         194     194              
  Lines       16134   16137       +3     
=========================================
+ Hits         7467    7472       +5     
+ Misses       8278    8276       -2     
  Partials      389     389

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
thaJeztah merged commit 898f1e2 into docker:master Aug 14, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.08.0 milestone Aug 14, 2017
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker history --human=false does not work according to docs

5 participants