Fix loader error with different build syntax - #544
Merged
Conversation
`build: .` was not working anymore. Fixing this by adding a new tranform function for BuildConfig. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
fix-build-loading
branch
from
September 20, 2017 12:02
7646849 to
0da9f14
Compare
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 49.06% 49.07% +<.01%
==========================================
Files 200 200
Lines 16438 16447 +9
==========================================
+ Hits 8066 8072 +6
- Misses 7952 7955 +3
Partials 420 420 |
Member
|
Do we know where it broke, and if this needs to be back ported? |
Collaborator
Author
|
@thaJeztah from #481. As we don't load it anyway in |
Contributor
|
@vdemeester kinda odd since |
cdrage
approved these changes
Sep 20, 2017
Collaborator
Author
|
@cdrage it's just that your PR didn't take into account |
Contributor
|
@vdemeester Doh. I forgot about that too. Thanks for the fix 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: .was not working anymore. Fixing this by adding a newtranform function for BuildConfig.
/cc @cdrage
Signed-off-by: Vincent Demeester vincent@sbr.pm