Add "pid" to unsupported options list - #768
Merged
Merged
Conversation
Services do not support custom "pid"-modes (e.g. `--pid=host`), but this
option was ignored silently when deploying a stack.
This patch adds `pid` to the list of unsupported options so that a warning
is printed;
With this patch applied:
$ docker stack deploy -c docker-compose.yml foobar
Ignoring unsupported options: pid
Creating network foobar_default
Creating service foobar_test
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
- Coverage 53.46% 53.46% -0.01%
==========================================
Files 218 218
Lines 14642 14642
==========================================
- Hits 7829 7828 -1
- Misses 6327 6328 +1
Partials 486 486 |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Add "pid" to unsupported options list Upstream-commit: 4a66821 Component: cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Services do not support custom "pid"-modes (e.g.
--pid=host, see moby/swarmkit#1605), but this option was ignored silently when deploying a stack.This patch adds
pidto the list of unsupported options so that a warning is printed;With this patch applied:
- How to verify it
Deploy this docker-compose file, and verify that a warning is printed;
- Description for the changelog