close
Skip to content

[Feature][Connector-V2] StarRocks-sink support schema evolution#8082

Merged
hailin0 merged 37 commits into
apache:devfrom
jw-itq:starrock-sink-ddl3
Dec 4, 2024
Merged

[Feature][Connector-V2] StarRocks-sink support schema evolution#8082
hailin0 merged 37 commits into
apache:devfrom
jw-itq:starrock-sink-ddl3

Conversation

@jw-itq

@jw-itq jw-itq commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

Feature #8034

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X

Copy link
Copy Markdown
Member

cc @hailin0 @dailai

}

@TestTemplate
public void testStarRocksSinkWithSchemaEvolutionCase(TestContainer container)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@jw-itq

jw-itq commented Nov 25, 2024

Copy link
Copy Markdown
Contributor Author

@hailin0 hi,can you help me see the reason why CI did not pass,thanks

}

try {
Connection conn =

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not close connection ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not close connection ?

sorry, I'll optimize it

Comment on lines +91 to +92
if (event instanceof AlterTableColumnsEvent) {
AlterTableColumnsEvent alterTableColumnsEvent = (AlterTableColumnsEvent) event;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference
#8158

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,thanks!

@hailin0

hailin0 commented Dec 2, 2024

Copy link
Copy Markdown
Member

Please fix the ci error

@jw-itq

jw-itq commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

Please fix the ci error

ok!

@jw-itq

jw-itq commented Dec 3, 2024

Copy link
Copy Markdown
Contributor Author

StarRocksTypeConverter referenced from #8087

@dailai dailai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit d33b0da into apache:dev Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants